Objective To identify the risk factors for diabetic kidney disease (DKD) development, especially the difference between patients with different courses. Patients and methods 791 patients were considered to be eligible and were enrolled in the cross-sectional study from Shanghai Tongren Hospital Inpatient Department. 36 variables were initially screened by univariate analysis. The risk factors affecting progression of DKD were determined by logistics regression analysis. Subgroups were grouped according to the course of diabetes disease, and multivariate logistics regression analysis was performed to find out the different risk factors in two subgroups. Finally, the receiver operating characteristics curve is used to verify the result. Results The logistic regression model indicated age (OR=1.020, p=0.017, 95% CI 1.004 to 1.040), systolic blood pressure (OR=1.013, p=0.006, 95% CI 1.004 to 1.022), waist circumference (OR=1.021, p=0.015, 95% CI 1.004 to 1.038), white blood cells (WBC, OR=1.185, p=0.001, 95% CI 1.085 to 1.295) and triglycerides (TG, OR=1.110, p=0.047, 95% CI 1.001 to 1.230) were risk factors for DKD, while free triiodothyronine (fT3, OR=0.711, p=0.011, 95% CI 0.547 to 0.926) was a protective factor for DKD in patients with type 2 diabetes mellitus (T2DM). Subgroup analysis revealed that in patients with a short duration of diabetes (<8 years), WBC (OR=1.306, p<0.001, 95% CI 1.157 to 1.475) and TG (OR=1.188, p=0.033, 95% CI 1.014 to 1.393) were risk factors for DKD,fT3 (OR=0.544, p=0.002, 95% CI 0.367 to 0.804) was a protective factor for DKD; whereas for patients with disease course more than 8 years, age (OR=1.026, Pp=0.012, 95%CI=95% CI[ 1.006- to 1.048]) was identified as the only risk factor for DKD and fT3 (OR=0.036, Pp=0.017, 95%CI=95% CI[ 0.439- to 0.922]) was a protective factor for DKD. Conclusion The focus of attention should especially be on patients with a prolonged course of T2DM, and those with comorbid hypertension and hypertriglyceridaemia waist phenotype. More potential clinical indexes such as thyroid function and inflammatory indicators might be considered as early warning factors for DKD in T2DM. Women should pay attention to controlling inflammation and TGs, and men should strictly control blood pressure. Avoiding abdominal obesity in both men and women will bring great benefits.